Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Publishing from RSS Guide #1151

Merged
merged 3 commits into from Dec 20, 2018
Merged

Added Publishing from RSS Guide #1151

merged 3 commits into from Dec 20, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 19, 2018

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Related Tickets & Documents

Closes #321.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Imgur

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Nov 19, 2018
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2018

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@stephaniekyyip stephaniekyyip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spend some time looking at the code behind the Feedjira parser. It seems like certain tags may be parsed differently depending on the type of feed. I could be overcomplicating things, but it might also be a little more complicated than it seems.

app/views/pages/_publishing_from_rss_guide_text.html.erb Outdated Show resolved Hide resolved
app/views/pages/_publishing_from_rss_guide_text.html.erb Outdated Show resolved Hide resolved
@jessleenyc
Copy link
Contributor

jessleenyc commented Dec 12, 2018

@moriczgergo would you like to make some of the updates/additional details suggested by @stephaniekyyip?

@ghost
Copy link
Author

ghost commented Dec 15, 2018

@jessleenyc yup! it'll be done by today.

@ghost
Copy link
Author

ghost commented Dec 15, 2018

Resolved, I think. @jessleenyc

@jessleenyc
Copy link
Contributor

@moriczgergo this looks good to me! Made some small copy changes but once it passes CI we can merge.

Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@maestromac maestromac merged commit 36f656c into forem:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: unreviewed bot applied label for PR's with no review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants