Don't display '0 reactions' on article feed #12425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
msarit
changed the title
msarit
added
the
merge by any core
rhymes
reviewed
Jan 26, 2021
| <span className="hidden s:inline"> | ||
| | ||
| {`${totalReactions == 1 ? 'reaction' : 'reactions'}`} | ||
| if (totalReactions > 0) { |
There was a problem hiding this comment.
I might be wrong here but I think you can return nothing immediately at the top of the function if the count is 0 because the rest of the component is just about rendering 1 or plus as the count
There was a problem hiding this comment.
makes sense 馃槃 I will modify
Comment on lines
9
to
10
| import '../../../../assets/javascripts/lib/xss'; | ||
| import '../../../../assets/javascripts/utilities/timeAgo'; |
There was a problem hiding this comment.
馃槄 you're right. I copied my test from the Article.test.jsx; these imports are the remnants of that move. I shall delete.
pr-triage
bot
removed
the
PR: draft
msarit
changed the title
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
View updated RRC here.
Do not display
0 reactionson the article feed card, when that article has zero reactions.Related Tickets & Documents
None
QA Instructions, Screenshots, Recordings
=> Implemented this change in 3 views; be sure to QA them all 馃檹馃従
UI accessibility concerns?
None
Added tests?
have not been included
Added to documentation?
Admin Guide
[optional] Are there any post deployment tasks we need to perform?
None
[optional] What gif best describes this PR or how it makes you feel?