Beginning of css variable implementation (--theme-background) #1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
Added --theme-background leaving the default the same. This will make no, visible, change to the styles currently.
7 tasks
Link2Twenty
changed the title
rkichenama
approved these changes
Dec 11, 2018
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: unreviewed
|
When this one is merged I'll do a couple more. |
benhalpern
approved these changes
Dec 19, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added --theme-background leaving the default the same.
This will make no, visible, change to the styles currently.
Adding CSS variables means loading a CSS file containing overrides means you can change the whole sites theme.
Related Tickets & Documents
#1104 and #1377
Added to documentation?