/connect rerender chat #1359
Merged
/connect rerender chat #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
removed
the
PR: unreviewed
benhalpern
approved these changes
Dec 18, 2018
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
When in 'dev.to/connect', clicking the paper airplane rerenders chat and triggers the
componentDidUpdate()function inchat.jsx, which callsscrollToBottom()fromutils.js.The error occurs because when
scrollToBottom()is called, the element it needsdocument.getElementById('messagelist')has not been rendered yet thus not being able to find thescrollHeightattribute. To avoid this, I added anifstatement incomponentDidUpdate()that checks thatdocument.getElementById('messagelist')is found before lettingscrollToBottom()be called.Related Tickets & Documents
Resolves #1357
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
See screenshots in #1357
Added to documentation?