Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag moderation info page #1360

Merged
merged 9 commits into from Dec 19, 2018
Merged

Add tag moderation info page #1360

merged 9 commits into from Dec 19, 2018

Conversation

jessleenyc
Copy link
Contributor

@jessleenyc jessleenyc commented Dec 18, 2018 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Updates the tag edit page "click here to see attributes" screenshot w/ current design.
  • Adds a route + guide to tag moderation

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

new page: /tag-moderation

new screenshot for tag edit page:

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Dec 18, 2018
pkfrank
pkfrank previously requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@pkfrank pkfrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make a few copy adjustments within the next few hours, so let's hold off on merging for right now.

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Dec 18, 2018
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Dec 18, 2018
@jessleenyc
Copy link
Contributor Author

@pkfrank made the changes you suggested

benhalpern
benhalpern requested changes Dec 18, 2018
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I see that jumps off the page as needing changes here is that we should wrap all images in cloudinary tags, for example: <%= cloudinary("https://thepracticaldev.s3.amazonaws.com/i/lgumfafaywo0zz90ciig.png") %>

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Dec 18, 2018
@pkfrank @jessleenyc
fix typo
7c8c81b 
Co-Authored-By: jessleenyc <jessleenyc@gmail.com>
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Dec 18, 2018
@jessleenyc
Copy link
Contributor Author

@benhalpern I believe I made the requested changes, also added some specs + email copy. Not sure if I wrote the 'go' conditional correctly, and also wasn't sure how to write the spec for that.
@pkfrank can you review more copy? specifically, the two email files.

@Link2Twenty
Copy link
Contributor

Having a way to update tag colours will help issue #1273

@benhalpern benhalpern merged commit 1d2a6de into forem:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkfrank pkfrank pkfrank left review comments

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: unreviewed bot applied label for PR's with no review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jessleenyc @Link2Twenty @benhalpern @pkfrank