Rubocop cleanups #1415
Merged
Rubocop cleanups #1415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
removed
the
PR: unreviewed
|
@maestromac @benhalpern @Zhao-Andy I know this is a giant blob of changes but it's mostly style issues and violations either autocorrected or fixed following the indications of the ruby style guide used by rubocop. It definitely needs one or more sets of eyes but it should be "innocuos". There are still few violations left but I'm stopping here for now :D |
pr-triage
bot
removed
the
PR: unreviewed
pr-triage
bot
added
the
PR: reviewed-approved
|
@maestromac thanks! |
pr-triage
bot
added
PR: unreviewed
benhalpern
approved these changes
Jan 2, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Inspired by @Zhao-Andy's post about Reek I started cleaning up the todo list for Rubocop violations.
The ones left in
rubocop_todo.ymlrequire a decision or refactoring or both:Related Tickets & Documents
Added to documentation?