Change the hard-coded current year to the current year #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hugmanrique
approved these changes
Jan 1, 2019
| @@ -2,7 +2,7 @@ | |||
| <div id="footer-container" class="container <%= "centered-footer" unless current_page.include?("stories-show") %>"> | |||
| <div class="inner-footer-container"> | |||
| <a href="/">Home</a> <a href="/about">About</a> <a href="/privacy">Privacy Policy</a> <a href="/terms">Terms of Use</a> <a href="/contact">Contact</a> <a href="/code-of-conduct">Code of Conduct</a> | |||
| DEV Community copyright 2018 🔥 | |||
| DEV Community copyright 2016 - <%= Time.new.year %> 🔥 | |||
There was a problem hiding this comment.
I would just display the current year, the same way it was before
There was a problem hiding this comment.
I probably would've done well to ask first. Might not be a bad idea to consult with an IP attorney, out of an abundance of caution, assuming the organization's intent to enforce the copyright. I have found multiple attorneys who offer similar guidance on their respective blogs and reference sites: https://danashultz.com/2013/10/09/copyright-notice-with-multiple-years-legitimate/
It's up to you. Thanks for the opportunity to contribute!
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: unreviewed
benhalpern
approved these changes
Jan 2, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
The current year is hard-coded in
_footer.html.erband_profile.html.erb. This PR makes the current year dynamic in both places.Related Tickets & Documents
This tweet
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?