Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous condition #1441

Merged
merged 1 commit into from Jan 1, 2019

Conversation

arku
Copy link
Contributor

@arku arku commented Jan 1, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Removes !user.summary.empty? from UserStates#fill_out_your_profile as it is the same as user.summary.present?.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 1, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Jan 1, 2019
@benhalpern benhalpern merged commit 0f8c086 into forem:master Jan 1, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: merged bot applied label for PR's that are merged labels Jan 1, 2019
@arku arku deleted the superfluous-condition-removal branch January 1, 2019 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants