Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user status to internal/users #1444

Merged
merged 13 commits into from Jan 3, 2019
Merged

Add user status to internal/users #1444

merged 13 commits into from Jan 3, 2019

Conversation

jessleenyc
Copy link
Contributor

@jessleenyc jessleenyc commented Jan 2, 2019 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Allow internal admins to update user role
  • Displays all user roles
  • Removes unnecessary mentorship details
  • Enhance styling

Screenshots




[optional] What gif best describes this PR or how it makes you feel?

alt_text

@jessleenyc jessleenyc changed the title [WIP] Add user status to internal/users Add user status to internal/users Jan 2, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 2, 2019
Zhao-Andy
Zhao-Andy approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 3, 2019
benhalpern
benhalpern approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@benhalpern benhalpern merged commit 4214bcb into forem:master Jan 3, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 3, 2019
@Zhao-Andy Zhao-Andy mentioned this pull request Jan 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

@Zhao-Andy Zhao-Andy Zhao-Andy approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jessleenyc @benhalpern @Zhao-Andy