Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve User profile form labels capitalization #1464

Merged
merged 1 commit into from Jan 6, 2019
Merged

Improve User profile form labels capitalization #1464

merged 1 commit into from Jan 6, 2019

Conversation

vinibrsl
Copy link
Contributor

@vinibrsl vinibrsl commented Jan 5, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This PR improves the links section in the User profile form. The labels had some capitalization problems that could be improved, such as "Facebook url" and "Stackoverflow url". With the changes, these labels now are "Facebook URL" and "Stack Overflow URL"

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 5, 2019
@CLAassistant
Copy link

CLAassistant commented Jan 5, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@benhalpern benhalpern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, thanks!

@benhalpern benhalpern merged commit 5831605 into forem:master Jan 6, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Jan 6, 2019
@vinibrsl vinibrsl deleted the patch-1 branch January 6, 2019 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged PR: reviewed-approved bot applied label for PR's where reviewer approves changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants