Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user signed in difference in article show comment form #1468

Merged
merged 1 commit into from Jan 6, 2019

Conversation

benhalpern
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Fix mistake where we differentiate between signed in and not but cache the result anyway. Causing improper cached version.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 6, 2019
@benhalpern benhalpern merged commit 9af401a into master Jan 6, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Jan 6, 2019
@maestromac maestromac deleted the ben/fix-caching-hiccup-articles branch January 8, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant