You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
benhalpern
merged 8 commits into
forem:master
from
rhymes:rhymes/export-commentsJan 16, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the list of allowed attributes needs to be finalized. @benhalpernhere listed those to remove. If reactions_count shouldn't be included then we should probably remove it from the export of the articles as well. Unless it works differently among the two resources
In the copy I changed data with content which seems less impersonal
I was wondering if in the comments export we should add some information about what the comment is attached to. Not the ancestry/tree information, but the path (or URL?) of the commentable. Otherwise the comment is a little "lost" in the export
I've removed the field reactions_count from both articles and comments and added commentable_path as an extra field in the comments export with the path (not the URL) for the resource the comment is attached to
PR: mergedbot applied label for PR's that are merged
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-triage
bot
added
PR: reviewed-approved
What type of PR is this? (check all applicable)
Description
I've added comments to the export and changed/updated the copy.
Related Tickets & Documents
#1461
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?