Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Ruby 2.6.0 #1482

Merged
merged 6 commits into from Jan 9, 2019
Merged

Upgrade to Ruby 2.6.0 #1482

merged 6 commits into from Jan 9, 2019

Conversation

vinistock
Copy link
Contributor

@vinistock vinistock commented Jan 7, 2019 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Upgrade Ruby version to the recently released 2.6.0.

Nokogiri, Webmock and Rubocop had to be upgraded as well to support the new Ruby.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@maestromac maestromac self-assigned this Jan 7, 2019
@vinistock
Copy link
Contributor Author

vinistock commented Jan 7, 2019 •
edited

@maestromac Rubocop is failing in Code Climate. I don't understand why, but Code Climate is running Rubocop 0.52.1 instead of the upgraded 0.62.0, which has breaking changes related to the .rubocop.yml configuration file. Everything else seems to be passing.

Any ideas on this one?

@rhymes
Copy link
Contributor

rhymes commented Jan 8, 2019

@vinistock you need to tell Codeclimate to change Rubocop's version, because it defaults to 0.52.1
https://docs.codeclimate.com/docs/rubocop#section-using-rubocop-s-newer-versions

@vinistock vinistock changed the title [WIP] Upgrade to Ruby 2.6.0 Upgrade to Ruby 2.6.0 Jan 8, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 8, 2019
@vinistock
Copy link
Contributor Author

I changed Rubocop's version in the .codeclimate.yml file. Thanks @rhymes for the info.

@maestromac
Copy link
Member

maestromac commented Jan 8, 2019 •
edited

Thanks for adding/updating .codeclimate.yml. It seems to be messing up our code climate's in-app config. I will move all of that configuration to this newly generated .codeclimate.yml.

maestromac
maestromac approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks for the PR!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 8, 2019
@vinistock
Copy link
Contributor Author

@maestromac cheers! Always happy to contribute.

@benhalpern benhalpern merged commit 0725b85 into forem:master Jan 9, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 9, 2019
@vinistock vinistock deleted the upgrade_to_ruby_2_6_0 branch January 9, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maestromac maestromac maestromac approved these changes

Assignees

@maestromac maestromac

Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vinistock @rhymes @maestromac @benhalpern