Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlideShare Liquid tag #1485

Merged
merged 9 commits into from Jan 10, 2019
Merged

SlideShare Liquid tag #1485

merged 9 commits into from Jan 10, 2019

Conversation

Link2Twenty
Copy link
Contributor

@Link2Twenty Link2Twenty commented Jan 8, 2019 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Added a liquid tag to allow embedding SlideShare slideshows

Related Tickets & Documents

#1483

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

Added to _editor_guide_text.html.erb

I did it!

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 8, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 8, 2019
@benhalpern
Copy link
Contributor

@Link2Twenty I think it's a random false positive but I'll look into it

@Zhao-Andy @Link2Twenty
More secure match
147a0b2 
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 8, 2019
@benhalpern @Link2Twenty
Strip whitespace
0148d7a 
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
Zhao-Andy
Zhao-Andy reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the two suggestions are accepted, this should be good to go!

app/liquid_tags/slideshare_tag.rb Outdated Show resolved Hide resolved
app/liquid_tags/slideshare_tag.rb Outdated Show resolved Hide resolved
Zhao-Andy and others added 2 commits January 8, 2019 18:18
@Zhao-Andy @Link2Twenty
Strip before regex
399ebce 
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
@Zhao-Andy @Link2Twenty
Remove latter strip
ee5b5d1 
Co-Authored-By: Link2Twenty <AndrewB05@gmail.com>
@Link2Twenty
Copy link
Contributor Author

@Zhao-Andy to help me understand why we need to the strip is it because everything after the slideshare is the key?

{% slideshare foo bar %}
tag_name = slideshare
key = foo bar

and if that is the case how would you then move on to the third parameter, tokens?

@Link2Twenty
Copy link
Contributor Author

@Zhao-Andy I had a play when doing my jsfiddle pull request, I think I get it now 🙂

@Zhao-Andy
Copy link
Contributor

Zhao-Andy commented Jan 10, 2019 •
edited

Hey @Link2Twenty, sorry just seeing this now! I believe the tokens argument is used by the LiquidTagBase class that the SlideshareTag class inherits from. It's not taken as an explicit user input, and my guess is that the Liquid gem does some magic that ends up using tokens.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 10, 2019
@benhalpern benhalpern merged commit 4673496 into forem:master Jan 10, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zhao-Andy Zhao-Andy Zhao-Andy left review comments

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Link2Twenty @benhalpern @Zhao-Andy