connect chat message markdown styling #1487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basically same as evaluate_markdown but without class attributes
mariocsee
changed the title
benhalpern
approved these changes
Jan 8, 2019
pr-triage
bot
removed
the
PR: unreviewed
pr-triage
bot
added
PR: reviewed-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Currently, messages sent in DEV Connect go through a markdown parser that allows for pre and code blocks, but non-inline elements like lists are ignored and broken down into one line as seen in issue #655.
This PR removes rules against non-inline elements and adds styling to prevent for example extremely large headers in messages. Examples made using Markdown Cheatsheet
Related Tickets & Documents
resolves #655
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Markdown now available in connect messages.
Added to documentation?