Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dashboard left side nav an unordered list #14887

Merged
merged 3 commits into from Oct 4, 2021
Merged

Make dashboard left side nav an unordered list #14887

merged 3 commits into from Oct 4, 2021

Conversation

secondl1ght
Copy link
Contributor

@secondl1ght secondl1ght commented Oct 1, 2021 •
edited by rhymes

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

As per issue #14841 I have made the dashboard left-side navigation an unordered list with the anchor elements as the list items. To improve quality of screen reading.

Related Tickets & Documents

Closes #14841

QA Instructions, Screenshots, Recordings

I don't believe this change will need any new tests to be written.

Added/updated tests?

  • Yes
  • No, and this is why: If tests need to be written for this change then please let me know.
  • I need help with writing tests

What gif best describes this PR or how it makes you feel?

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 1, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2021

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@secondl1ght secondl1ght changed the title Make dashboard left side nav an unordered list 14841 Make dashboard left side nav an unordered list Oct 1, 2021
@secondl1ght secondl1ght mentioned this pull request Oct 1, 2021
Closed
aitchiss
aitchiss reviewed Oct 4, 2021
View reviewed changes
Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this on! I've left one small suggestion to tweak the class names so that visually nothing changes 👍

app/views/dashboards/_actions.html.erb Outdated Show resolved Hide resolved
@msarit
Copy link
Contributor

msarit commented Oct 4, 2021

@secondl1ght Hey there! Thank you for the PR! 👋🏾
Please remember to sign the CLA!

msarit
msarit approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@msarit msarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@secondl1ght This PR looks great, thanks for contributing.

I'm approving, assuming you will incorporate Suzanne's suggestion here.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 4, 2021
@secondl1ght @aitchiss
Add correct class to new ul element so that nothing changes visually
c5d9c44 
Suggested by @aitchiss and tested by @msarit, I thought some css styling may need to be applied, thanks!

Co-authored-by: Suzanne Aitchison <suzanne@forem.com>
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 4, 2021
@secondl1ght
Copy link
Contributor Author

@aitchiss @msarit thanks so much for the help on this, this was my first time receiving comments back on a PR and committing the changes suggested so that was cool to see how it works! I believe everything should be ready to merge now. :)

rhymes
rhymes approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you @secondl1ght and welcome to Forem :)

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 4, 2021
@rhymes rhymes merged commit 2b98b47 into forem:main Oct 4, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aitchiss aitchiss aitchiss left review comments

@rhymes rhymes rhymes approved these changes

@msarit msarit msarit approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dashboard left-side navigation should be a list
5 participants
@secondl1ght @CLAassistant @msarit @rhymes @aitchiss