Fix Prop Types Error #14837

[papuruth]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

As per issue no. #14837 I have fixed prop types errors for Button, ButtonGroup, Modal, and articlePage components.

Related Tickets & Documents

#14837

QA Instructions, Screenshots, Recordings

I don't believe any new tests would be required for these changes.

Added/updated tests?

• No, as because it doesn't seem legit to write UT for these changes.

[optional] What gif best describes this PR or how it makes you feel?

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[aitchiss]

Thanks for taking this on! It's looking great, but I just have a couple of small change requests - let me know if I can assist at all!

[aitchiss]

refactor (blocking) - I'm not sure this is the correct fix, as we don't want booleans passed in as children of the ButtonGroup (we only want elements/Preact components 🙂 ).

Instead of changing this to silence the error, I would instead update the code using ButtonGroup and triggering the error:

forem/app/javascript/CommentSubscription/CommentSubscription.jsx

Lines 131 to 139 in e7af2bf

	{subscribed && (
	<Button
	id="subscription-settings-btn"
	data-testid="subscription-settings"
	variant="outlined"
	icon={CogIcon}
	contentType="icon"
	/>
	)}

We could use a ternary to avoid passing a false boolean into the component, e.g.:

{subscribed ? (
            <Button
              id="subscription-settings-btn"
              data-testid="subscription-settings"
              variant="outlined"
              icon={CogIcon}
              contentType="icon"
            />
          ) : null}

[papuruth]

Exactly we should pass null @aitchiss

[papuruth]

I have pushed the changes please review

[aitchiss]

Thanks for making those changes! ✨