Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I18n copy on Tags index page #14891

Merged
merged 7 commits into from Oct 8, 2021
Merged

I18n copy on Tags index page #14891

merged 7 commits into from Oct 8, 2021

Conversation

lsparlin
Copy link
Contributor

@lsparlin lsparlin commented Oct 2, 2021 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

Added/updated tests?

  • Yes
  • No, and this is why: on-page copy does not change
  • I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

  • I've updated the Developer Docs or
    Storybook (for Crayons components)
  • This PR changes the Forem platform and our documentation needs to be
    updated. I have filled out the
    Changes Requested
    issue template so Community Success can help update the Admin Docs
    appropriately.
  • I've updated the README or added inline documentation
  • I've added an entry to
    CHANGELOG.md
  • I will share this change in a Changelog
    or in a forem.dev post
  • I will share this change internally with the appropriate teams
  • I'm not sure how best to communicate this change and need help
  • This change does not need to be communicated, and this is why not: please
    replace this line with details on why this change doesn't need to be
    shared

@pr-triage pr-triage bot added the PR: draft bot applied label for PR's that are a work in progress label Oct 2, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2021

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@lsparlin lsparlin marked this pull request as ready for review October 4, 2021 18:38
@lsparlin lsparlin requested a review from a team as a code owner October 4, 2021 18:38
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: draft bot applied label for PR's that are a work in progress labels Oct 4, 2021
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 4, 2021
citizen428
citizen428 suggested changes Oct 5, 2021
View reviewed changes
app/views/tags/index.html.erb Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 5, 2021
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Oct 5, 2021
@rhymes rhymes requested a review from citizen428 October 6, 2021 16:17
@maestromac maestromac removed the request for review from a team October 7, 2021 20:12
citizen428
citizen428 reviewed Oct 8, 2021
View reviewed changes
config/locales/fr.yml
@@ -35,6 +37,9 @@ fr:
search: Recherche
see_all: Tout voir
share_to: Partager sur %{media}
tags: Sujets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check: do you speak French or was this translation done with something like Google translate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not speak French. I inferred this one from an existing line in fr.yml - my_tags: Mes sujets. Others I looked up using Google or Microsoft Terminology Search

Copy link
Contributor

@citizen428 citizen428 Oct 8, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I guess it will do for now, thanks for clarifying!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 8, 2021
@citizen428 citizen428 merged commit 30b36ab into forem:main Oct 8, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

@citizen428 citizen428 citizen428 approved these changes

@maestromac maestromac Awaiting requested review from maestromac

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lsparlin @CLAassistant @citizen428 @benhalpern