Replace main tag inside another main tag with div #14896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
aitchiss
approved these changes
Oct 4, 2021
pr-triage
bot
added
PR: partially-approved
aitchiss
requested review from
a team,
nickytonline and
msarit
and removed request for
a team
nickytonline
approved these changes
Oct 4, 2021
|
Oops! You showed up in the autocomplete first. My bad. 🙃 Thanks so much @luhova! |
|
Thanks so much for the help here @luhova 🥳 |
pr-triage
bot
added
PR: unreviewed
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Replace main tag inside another main tag with div inside the notifcations page.
Related Tickets & Documents
Fixes #14879
QA Instructions, Screenshots, Recordings
/notificationsUI accessibility concerns?
Added/updated tests?
[Forem core team only] How will this change be communicated?
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?