Add a notification on password reset

[mrmir]

What type of PR is this? (check all applicable)

• Feature

Description

Changes made:

1. Adds a notice on clicking the "Send me password reset instructions" button

Related Tickets & Documents

Resolves #10130

QA Instructions, Screenshots, Recordings

1. Visit /users/password/new
2. Enter email ID and click submit
3. A notice should appear on the /enter page that the app is redirected to

UI accessibility concerns?

No

Added/updated tests?

• [ x] No, and this is why: Existing tests should suffice since only one line has been added

[optional] What gif best describes this PR or how it makes you feel?

[CLAassistant]

All committers have signed the CLA.

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[citizen428]

The reason we don't send a notification is that we didn't want to leak any information as to whether or not an address actually exists. Previously we showed either that the notification was sent or an error. I think a generic unconditional message is ok.

[rhymes]

@citizen428 @mrmir I think the fix is correct but while I was testing it I noticed the redirect doesn't work at all, on DEV it lands on a 404 page and I get a routing error locally as well:

Screen.Recording.2021-10-07.at.12.36.13.mov

which means that the feature might not be working at all. Maybe we want to hold off on merging this until we understand why the feature is not working

[mrmir]

@rhymes I don't know what's happening in your tests, but I just checked again and it seems to be redirecting fine for me. I'm running the app via bin/startup after following the developer documentation setup.

[benhalpern]

Seeing if closing and re-opening will trigger tests appropriately

[msarit]

@benhalpern Are we sure the author does not need to add/modify any tests?
I could've sworn there's an E2E test for this flow. Perhaps its straightforward enough not to need one...

[benhalpern]

@benhalpern Are we sure the author does not need to add/modify any tests?

Yeah @msarit. The PR in the end really doesn't affect functionality enough to need a whole new tests. If regression tests pass we're good to go here.

The problem was just that the PR never even kicked off a Travis job. Tests weren't failing, they just never started. So now they ran and are green so I'm going to merge this.