Fix PropTypes Error Create New Post Page #14969
Conversation
papuruth
requested review from
a team,
nickytonline and
Ridhwana
and removed request for
a team
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
rhymes
requested review from
aitchiss and
rhymes
and removed request for
nickytonline and
Ridhwana
There was a problem hiding this comment.
Nice work!
I've left a couple of suggestions, but they're not blocking. I also noticed that if you're a member of an organization, there are still a few PropTypes errors being logged out on this page.
It can always be tackled separately, so I'll leave it up to you whether to tackle those errors here too.
Thanks for tidying up these errors! 🧹 ✨
| @@ -65,7 +65,7 @@ export class ArticleForm extends Component { | |||
| }; | |||
|
|
|||
| static defaultProps = { | |||
| organizations: '', | |||
| organizations: '[]', | |||
There was a problem hiding this comment.
I'm not sure this is needed - I can't see any error being flagged for the current default prop?
| @@ -24,7 +24,7 @@ export const ErrorList = ({ errors }) => { | |||
| }; | |||
|
|
|||
| ErrorList.propTypes = { | |||
| errors: PropTypes.objectOf(PropTypes.string).isRequired, | |||
| errors: PropTypes.object.isRequired, | |||
There was a problem hiding this comment.
| errors: PropTypes.object.isRequired, | |
| errors: PropTypes.objectOf(PropTypes.arrayOf(PropTypes.string)).isRequired |
suggestion (not blocking) - we could make these even more specific, since we know the object values should all be arrays of strings
| * @param {boolean} props.previewShowing Boolean to decide if to show the preview | ||
| * @param {string} props.helpFor Section for which help is shown | ||
| * @param {string} props.helpPosition Offset from the top of the help component | ||
| * @param {number} props.helpPosition Offset from the top of the help component |
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: merged
What type of PR is this? (check all applicable)
Description
Fixes PropTypes error in Create new post page
Related Tickets & Documents
#14837
Added/updated tests?
[optional] What gif best describes this PR or how it makes you feel?