I18nize main_nav's "Home" #14982
Merged
I18nize main_nav's "Home" #14982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lization YAML files.
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
|
pr-triage
bot
added
PR: partially-approved
maestromac
approved these changes
Oct 7, 2021
pr-triage
bot
added
PR: reviewed-approved
maestromac
changed the title
pr-triage
bot
added
PR: merged
KrystalJean
deleted the
KrystalJean/Internationalize-Hardcoded-Display-Text-#14888
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lization YAML files.
What type of PR is this? (check all applicable)
Description
This follows existing patterns of internationalization to translate the home button on main nav.
The only added translation is "Home".
Related Tickets & Documents
This PR is related to Internationalize Hardcoded Display Text #14888 .
This will not close the issue as it is an ongoing new feature project.
QA Instructions, Screenshots, Recordings
This is my second year participating in Hacktoberfest. I am still very new to anything back end, but I have followed the instructions to the DEV post (https://dev.to/devteam/forem-hacktoberfest-let-s-internationalize-404n) for this solution. Any constructive criticism is welcome.
UI accessibility concerns?
Added/updated tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?