Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate some labels from profile information #15002

Merged
merged 2 commits into from Oct 11, 2021
Merged

Translate some labels from profile information #15002

merged 2 commits into from Oct 11, 2021

Conversation

mtayllan
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

This add Internationalization to some labels from profile information.

Related Tickets & Documents

https://dev.to/devteam/forem-hacktoberfest-let-s-internationalize-404n
#14888

QA Instructions, Screenshots, Recordings

image
image

UI accessibility concerns?

None

Added/updated tests?

  • Yes
  • No, and this is why: existing regression tests should suffice
  • I need help with writing tests

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 10, 2021
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@mtayllan mtayllan changed the title Translate some labels from profle information Translate some labels from profile information Oct 10, 2021
Arun-kc
Arun-kc reviewed Oct 11, 2021
View reviewed changes
Copy link
Contributor

@Arun-kc Arun-kc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small comment on the translation part.
If it is an invalid comment then, LGTM 👍

config/locales/fr.yml Outdated
@@ -22,9 +22,12 @@ fr:
full: Complet
home: Page D'Accueil
infinity: Infini
joined: Rejoint
joined_on: Rejoint en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be Rejoint en or Rejoint le ?? I don't know French, I just checked it in Google translation. It showed Joined on as Rejoint le

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arun-kc good call, it should be Rejoint le as it's followed by a date

rhymes
rhymes suggested changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@rhymes rhymes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mtayllan, left some change requests, thanks for tackling this!

config/locales/fr.yml Outdated
latest: Récent
like: Aime
listings: Annonces
location: Emplacement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should use Lieu here, as "Location" is used as a synonym for "place". We want to know where they are located on the globe

config/locales/fr.yml Outdated
@@ -22,9 +22,12 @@ fr:
full: Complet
home: Page D'Accueil
infinity: Infini
joined: Rejoint
joined_on: Rejoint en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arun-kc good call, it should be Rejoint le as it's followed by a date

@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 11, 2021
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Oct 11, 2021
@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 11, 2021
@rhymes rhymes requested review from a team, joshpuetz and Zhao-Andy and removed request for a team October 11, 2021 12:15
@benhalpern benhalpern merged commit 75df8e1 into forem:main Oct 11, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 11, 2021
This was referenced Oct 12, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 12, 2021
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arun-kc Arun-kc Arun-kc left review comments

@rhymes rhymes rhymes approved these changes

@benhalpern benhalpern benhalpern approved these changes

@joshpuetz joshpuetz Awaiting requested review from joshpuetz

@Zhao-Andy Zhao-Andy Awaiting requested review from Zhao-Andy

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mtayllan @rhymes @benhalpern @Arun-kc