When a user is blocked from commenting on an article, show correct error message #15009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pr-triage
bot
added
the
PR: draft
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
pr-triage
bot
added
PR: unreviewed
citizen428
reviewed
Oct 12, 2021
fdocr
reviewed
Oct 12, 2021
pr-triage
bot
added
PR: partially-approved
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Instead of letting Pundit handle this policy, I moved the logic to the controller method. This way all other pundit validations will continue to work as before. The controller will raise an
UnauthorizedErrorwhich will be handled by the controller to return a proper error message.Related Tickets & Documents
Closes #14642
And perhaps a similar issue #14502
Probable Changes
QA Instructions, Screenshots, Recordings
Recreation can be found here -#14642 (comment)
Added/updated tests?