Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove callbacks from banisher + specs! #1501

Merged
merged 2 commits into from Jan 9, 2019
Merged

Remove callbacks from banisher + specs! #1501

merged 2 commits into from Jan 9, 2019

Conversation

jessleenyc
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

  • Removed all callbacks from /banish.
  • Wrote specs
  • Manually checked algolia indexing and all seems to be good here
  • Still don't know how to 'test' fastly.

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 8, 2019
@jessleenyc jessleenyc changed the title Remove callbacks from banisher + specs! [WIP] Remove callbacks from banisher + specs! Jan 9, 2019
@pr-triage pr-triage bot removed the PR: unreviewed bot applied label for PR's with no review label Jan 9, 2019
@jessleenyc jessleenyc force-pushed the jess/1114/cache-busting-not-working branch from 6213f48 to fe9a165 Compare January 9, 2019 18:39
@jessleenyc jessleenyc changed the title [WIP] Remove callbacks from banisher + specs! Remove callbacks from banisher + specs! Jan 9, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 9, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 9, 2019
@benhalpern benhalpern merged commit 5e4508e into forem:master Jan 9, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 9, 2019
@jessleenyc jessleenyc mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhalpern benhalpern benhalpern approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jessleenyc @benhalpern