views/onboardings i18n

[yheuhtozr]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Extracts strings for i18n from app/views/onboardings. Attached fr and ja locales for testing purposes. Existing translations up to #15002 reflected (hopefully).

Related Tickets & Documents

#14888

QA Instructions, Screenshots, Recordings

Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.

UI accessibility concerns?

If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the
Forem Accessibility Docs.

Added/updated tests?

• Yes
• No, and this is why: please replace this line with details on why tests
  have not been included
• I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

• I've updated the Developer Docs or
  Storybook (for Crayons components)
• This PR changes the Forem platform and our documentation needs to be
  updated. I have filled out the
  Changes Requested
  issue template so Community Success can help update the Admin Docs
  appropriately.
• I've updated the README or added inline documentation
• I've added an entry to
  CHANGELOG.md
• I will share this change in a Changelog
  or in a forem.dev post
• I will share this change internally with the appropriate teams
• I'm not sure how best to communicate this change and need help
• This change does not need to be communicated, and this is why not: please
  replace this line with details on why this change doesn't need to be
  shared

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

[github-actions]

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

[citizen428]

Same comments as the other PR:

1. I'd prefer to not use scope
2. I don't think v is a great namespace name
3. Only en and fr, no ja for now.

Additionally, we should consistently use t with parenthesis, not sometimes with and sometimes without.

[yheuhtozr]

Thank you for reviewing.

1. I'd prefer to not use scope

Sure. Just in case do you mean full key for all strings or use implicit prefix like .translate.key? (I don't like the latter though.)
Saw your other comment.

2. I don't think v is a great namespace name

Yes, but do you mean just remove the v in the middle? FYI on this matter, I thought it might be safer to use an umbrella namespace for strings that come from views, because one third of translatable strings I found are written in elsewhere whose relationship with views classification are not immediately clear.

3. Only en and fr, no ja for now.

I see. I thought it sometimes handy for the explanation why I cut out a string in a certain manner.

Additionally, we should consistently use t with parenthesis, not sometimes with and sometimes without.

Will change.

[citizen428]

Thank you, this is great! 👏

[rhymes]

Thanks @yheuhtozr!