New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
views/listings etc i18n #15040
views/listings etc i18n #15040
Conversation
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s |
dd1d6a8
to
26f2952
Compare
@citizen428 Travis reports six missing i18n keys which are not detected on my machine. |
I think this may be related to a PR one of our team members did not too long ago where they removed error messages that weren't changed from the default from |
Co-authored-by: Michael Kohl <citizen428@forem.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* views/listings etc i18n * helper labels * remove ja.yml * Update edit.html.erb * Apply suggestions from code review Co-authored-by: Michael Kohl <citizen428@forem.com> * Update delete_confirm.html.erb * Update edit.html.erb * Update fr.yml * Update edit.html.erb Co-authored-by: Michael Kohl <citizen428@forem.com>
What type of PR is this? (check all applicable)
Description
Extracts strings for i18n from app/views/listings and related. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).
Related Tickets & Documents
Relates to #14888
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
Added/updated tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.md
or in a forem.dev post
[optional] Are there any post deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?