Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

views/listings etc i18n #15040

Merged
merged 10 commits into from Oct 27, 2021
Merged

views/listings etc i18n #15040

merged 10 commits into from Oct 27, 2021

Conversation

yheuhtozr
Copy link
Contributor

@yheuhtozr yheuhtozr commented Oct 12, 2021 •
edited by juliannatetreault

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Extracts strings for i18n from app/views/listings and related. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).

Related Tickets & Documents

Relates to #14888

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

  • Yes
  • No, and this is why: please replace this line with details on why tests
    have not been included
  • I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

  • I've updated the Developer Docs or
    Storybook (for Crayons components)
  • This PR changes the Forem platform and our documentation needs to be
    updated. I have filled out the
    Changes Requested
    issue template so Community Success can help update the Admin Docs
    appropriately.
  • I've updated the README or added inline documentation
  • I've added an entry to
    CHANGELOG.md
  • I will share this change in a Changelog
    or in a forem.dev post
  • I will share this change internally with the appropriate teams
  • I'm not sure how best to communicate this change and need help
  • This change does not need to be communicated, and this is why not: this is ongoing work related to a large, ongoing initiative.

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 12, 2021
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@yheuhtozr yheuhtozr changed the title views/listings i18n views/listings etc i18n Oct 12, 2021
@juliannatetreault
Copy link
Contributor

juliannatetreault commented Oct 14, 2021 •
edited

Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s main branch? i18n files weren’t being loaded properly and we have merged a fix for this. Thanks so much in advance and please do not hesitate to reach out if you need help!

@yheuhtozr yheuhtozr mentioned this pull request Oct 20, 2021
Closed
16 tasks
@yheuhtozr
Copy link
Contributor Author

@citizen428 Travis reports six missing i18n keys which are not detected on my machine.

citizen428
citizen428 reviewed Oct 25, 2021
View reviewed changes
app/views/listings/_form.html.erb Outdated Show resolved Hide resolved
app/views/listings/_form.html.erb Outdated Show resolved Hide resolved
app/views/listings/_form.html.erb Outdated Show resolved Hide resolved
app/views/listings/_form.html.erb Outdated Show resolved Hide resolved
app/views/listings/_form.html.erb Outdated Show resolved Hide resolved
config/locales/views/listings/fr.yml Outdated Show resolved Hide resolved
config/locales/views/listings/fr.yml Outdated Show resolved Hide resolved
config/locales/views/listings/fr.yml Outdated Show resolved Hide resolved
config/locales/views/listings/fr.yml Outdated Show resolved Hide resolved
config/locales/views/listings/fr.yml Outdated Show resolved Hide resolved
@yheuhtozr
Copy link
Contributor Author

Now I realized my branch's i18n-tasks.yml was outdated and got the six missing keys, but they don't seem from my changeset...

image

@citizen428
Copy link
Contributor

Now I realized my branch's i18n-tasks.yml was outdated and got the six missing keys, but they don't seem from my changeset...

I think this may be related to a PR one of our team members did not too long ago where they removed error messages that weren't changed from the default from en.yml. It probably makes sense to revert this but probably as a separate PR, not as part of this (or maybe we can teach I18n tasks about the exception because as far as I can tell the translations exist and will be picked up, they just aren't in a place where the task expects them to be.

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 27, 2021
aitchiss
aitchiss approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@aitchiss aitchiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 27, 2021
@aitchiss aitchiss merged commit 824397b into forem:main Oct 27, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 27, 2021
citizen428 added a commit that referenced this pull request Oct 29, 2021
@yheuhtozr @citizen428
views/listings etc i18n (#15040)
16224b8 
* views/listings etc i18n

* helper labels

* remove ja.yml

* Update edit.html.erb

* Apply suggestions from code review

Co-authored-by: Michael Kohl <citizen428@forem.com>

* Update delete_confirm.html.erb

* Update edit.html.erb

* Update fr.yml

* Update edit.html.erb

Co-authored-by: Michael Kohl <citizen428@forem.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizen428 citizen428 citizen428 approved these changes

@aitchiss aitchiss aitchiss approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yheuhtozr @juliannatetreault @citizen428 @aitchiss