New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
views/reading_list_items i18n #15041
views/reading_list_items i18n #15041
Conversation
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of quick, non-blocking questions, otherwise this looks good! It does, however, look like there are some failing specs that need to be addressed.
|
@juliannatetreault Hopefully I have taken care of an ERB error. |
As I write this comment, it looks like there might just be some merge conflicts to resolve, @yheuhtozr! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, @yheuhtozr! ✨
What type of PR is this? (check all applicable)
Description
Extracts strings for i18n from app/views/reading_list_items. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).
Related Tickets & Documents
Relates to #14888
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
Added/updated tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?