Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18nize nav_menu's list items #15055

Merged
merged 3 commits into from Oct 14, 2021
Merged

I18nize nav_menu's list items #15055

merged 3 commits into from Oct 14, 2021

Conversation

KrystalJean
Copy link
Contributor

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

I followed existing patterns of internationalization to translate the list items found in nav_menu.

I I18nized a total of seven list items (two of those already had translations for English, and French).
Li's include: Admin, Dashboard, Moderator Center, Create Post, Reading List, Settings, and Sign Out.

Related Tickets & Documents

This PR references issue "Internationalize Hardcoded Display Text #14888".
This will not close the issue as it is an ongoing new feature project.

QA Instructions, Screenshots, Recordings

UI accessibility concerns? none

Forem Accessibility Docs._

Added/updated tests? no

  • Yes
  • No, and this is why: Existing tests should suffice.
  • I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

  • I've updated the Developer Docs or
    Storybook (for Crayons components)
  • This PR changes the Forem platform and our documentation needs to be
    updated. I have filled out the
    Changes Requested
    issue template so Community Success can help update the Admin Docs
    appropriately.
  • I've updated the README or added inline documentation
  • I've added an entry to
    CHANGELOG.md
  • I will share this change in a Changelog
    or in a forem.dev post
  • I will share this change internally with the appropriate teams
  • I'm not sure how best to communicate this change and need help
  • This change does not need to be communicated, and this is why not: please
    replace this line with details on why this change doesn't need to be
    shared

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

alt_text

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 12, 2021
@github-actions
Copy link
Contributor

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

@pr-triage pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 13, 2021
Copy link
Contributor

@msarit msarit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @KrystalJean! 🚀 Thank you for contributing!

I checked the translations and all looks copacetic 👌🏾

To fix the failing Travis tests, check the file cypress/integration/seededFlows/topNavigationFlows/MemberDropDownButton.spec.js.

Let me know if you need help running Cypress locally and making the changes. ❤️

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 13, 2021
@citizen428
Copy link
Contributor

The test is failing because the string changed from "Reading list" to "Reading List". I'm taking the liberty to fix this myself because I want to get this PR merged because I'm in the process of doing some I18n cleanup work.

@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Oct 14, 2021
@KrystalJean
Copy link
Contributor Author

Okay thank you @citizen428. I completely forgot about changing that capitalization.
And thank you @msarit so much for your sweet comment. Sorry I am just responding, but I have been working all day on trying to install all of the prerequisites to run this code locally, and figure out what was happening.

@citizen428
Copy link
Contributor

Thanks a lot for your contribution @KrystalJean, it's much appreciated! 👏

@citizen428 citizen428 merged commit 49e1434 into forem:main Oct 14, 2021
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: unreviewed bot applied label for PR's with no review labels Oct 14, 2021
@KrystalJean
Copy link
Contributor Author

No problem @citizen428 . I am glad I could help, as well as gain some knowledge, and confidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants