New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I18nize nav_menu's list items #15055
I18nize nav_menu's list items #15055
Conversation
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
… test in Travis CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great @KrystalJean! 🚀 Thank you for contributing!
I checked the translations and all looks copacetic 👌🏾
To fix the failing Travis tests, check the file cypress/integration/seededFlows/topNavigationFlows/MemberDropDownButton.spec.js.
Let me know if you need help running Cypress locally and making the changes. ❤️
|
The test is failing because the string changed from "Reading list" to "Reading List". I'm taking the liberty to fix this myself because I want to get this PR merged because I'm in the process of doing some I18n cleanup work. |
|
Okay thank you @citizen428. I completely forgot about changing that capitalization. |
|
Thanks a lot for your contribution @KrystalJean, it's much appreciated! 👏 |
|
No problem @citizen428 . I am glad I could help, as well as gain some knowledge, and confidence. |
What type of PR is this? (check all applicable)
Description
I followed existing patterns of internationalization to translate the list items found in nav_menu.
I I18nized a total of seven list items (two of those already had translations for English, and French).
Li's include: Admin, Dashboard, Moderator Center, Create Post, Reading List, Settings, and Sign Out.
Related Tickets & Documents
This PR references issue "Internationalize Hardcoded Display Text #14888".
This will not close the issue as it is an ongoing new feature project.
QA Instructions, Screenshots, Recordings
UI accessibility concerns? none
Forem Accessibility Docs._
Added/updated tests? no
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?