actions and reactions i18n #15058

yheuhtozr · 2021-10-13T02:30:46Z

What type of PR is this? (check all applicable)

Description

Extracts actions or reactions related strings for i18n. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).

Related Tickets & Documents

Relates to #14888

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

Yes
No, and this is why: please replace this line with details on why tests
have not been included
I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

I've updated the Developer Docs or
Storybook (for Crayons components)
This PR changes the Forem platform and our documentation needs to be
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
I've updated the README or added inline documentation
I've added an entry to
CHANGELOG.md
I will share this change in a Changelog
or in a forem.dev post
I will share this change internally with the appropriate teams
I'm not sure how best to communicate this change and need help
This change does not need to be communicated, and this is why not: this is ongoing work related to a large, ongoing initiative.

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

github-actions · 2021-10-13T02:30:59Z

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

app/views/articles/_actions.html.erb

yheuhtozr · 2021-10-13T08:19:30Z

config/locales/views/reactions/fr.yml

+          other: "%{count}%{start}\_réactions%{end}"
+        title: Reactions
+      like:
+        title: Coeur


BTW, are French speakers fine with Coeur instead of Cœur? (I just copied from another commit as it is.)

I think this is ok for now, we can do another pass through the files at a later stage when they have settled down a bit more.

juliannatetreault · 2021-10-14T18:39:31Z

Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s main branch? i18n files weren’t being loaded properly and we have merged a fix for this. Thanks so much in advance and please do not hesitate to reach out if you need help!

juliannatetreault

This is looking good so far! I have two comments, one that is inline and one that I will mention here: I noticed that there is a fair amount of whitespace beneath the Reading List (please see the attached screenshot for reference) and I don't seem to experience this on main. Are you also experiencing this?

app/views/notifications/_aggregated_reactions.html.erb

citizen428

I'm approving this before the merge conflicts have been resolved but this looks good so far.

citizen428 · 2021-10-21T05:23:20Z

There's an issue with views.notifications.reacted.and_other_html in both translation files it seems.

yheuhtozr · 2021-10-21T05:28:37Z

@citizen428 Thank you, but it is strange. The key is apparently there in both locale files.

forem/config/locales/views/notifications/en.yml

Lines 1 to 13 in fa1438a

    
           --- 
        
           en: 
        
             views: 
        
               notifications: 
        
                 reacted: 
        
                   and_html: "%{first} and %{last}" 
        
                   and_other_html: 
        
                     other: "%{first} and %{count} others" 
        
                   verb_html: 
        
                     other: "%{start}%{actors} reacted to %{title} with%{end} %{reactions}" 
        
                   your: 
        
                     article: your article 
        
                     comment: your comment

citizen428 · 2021-10-21T05:30:44Z

@yheuhtozr See the last column, this is about having a count and not providing a one translation, only an other translation. I know it's a bit weird as we don't really need it but i18n-tasks seems to be strict in this regard.

yheuhtozr · 2021-10-21T05:56:28Z

@citizen428 BTW is it possible to have i18n-tasks show in the error output which keys are missing?

citizen428 · 2021-10-21T05:59:53Z

Do you mean during the spec run?

yheuhtozr · 2021-10-21T06:06:21Z

Yes, that's what I meant.

citizen428 · 2021-10-21T06:07:39Z

No, and I don't think we'll add that. But: you can make a copy of the file, add it to gitignore, add whatever output you want and run that locally.

* actions and reactions i18n * remove ja.yml * Update en.yml * Update fr.yml * Update _actions.html.erb

pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 13, 2021

citizen428 reviewed Oct 13, 2021

View reviewed changes

app/views/articles/_actions.html.erb Outdated Show resolved Hide resolved

yheuhtozr commented Oct 13, 2021

View reviewed changes

yheuhtozr added 2 commits October 14, 2021 19:48

actions and reactions i18n

8c41fe3

remove ja.yml

fe2bb6c

yheuhtozr force-pushed the patch-actions-reactions-i18n-14888 branch from 4d337d1 to fe2bb6c Compare October 14, 2021 10:53

juliannatetreault reviewed Oct 15, 2021

View reviewed changes

app/views/notifications/_aggregated_reactions.html.erb Show resolved Hide resolved

citizen428 approved these changes Oct 18, 2021

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 18, 2021

Merge branch 'main' into patch-actions-reactions-i18n-14888

fa1438a

pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 21, 2021

yheuhtozr added 2 commits October 21, 2021 14:35

Update en.yml

3fb5ed2

Update fr.yml

178d259

citizen428 approved these changes Oct 21, 2021

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 21, 2021

citizen428 requested a review from juliannatetreault October 21, 2021 05:53

Update _actions.html.erb

61f448f

pr-triage bot removed the PR: partially-approved bot applied label for PR's where a single reviewer approves changes label Oct 21, 2021

pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 21, 2021

Merge branch 'main' into patch-actions-reactions-i18n-14888

43f9907

juliannatetreault approved these changes Oct 25, 2021

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 25, 2021

juliannatetreault merged commit ffd8c9e into forem:main Oct 25, 2021

pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 25, 2021

Zhao-Andy mentioned this pull request Oct 25, 2021

Add back reaction translations #15194

Merged

1 task

djuber mentioned this pull request Oct 25, 2021

Add reaction to articles when seeding the database #15193

Merged

9 tasks

cmgorton mentioned this pull request Oct 26, 2021

"An error occurred" warning in notifications #15205

Closed

djuber mentioned this pull request Oct 26, 2021

Cleanup single reaction template #15207

Merged

9 tasks

citizen428 pushed a commit that referenced this pull request Oct 29, 2021

actions and reactions i18n (#15058)

323b9e6

* actions and reactions i18n * remove ja.yml * Update en.yml * Update fr.yml * Update _actions.html.erb

actions and reactions i18n #15058

actions and reactions i18n #15058

yheuhtozr commented Oct 13, 2021 •

edited by juliannatetreault

github-actions bot commented Oct 13, 2021

yheuhtozr Oct 13, 2021 •

edited

citizen428 Oct 18, 2021

juliannatetreault commented Oct 14, 2021

juliannatetreault left a comment

citizen428 left a comment

citizen428 commented Oct 21, 2021 •

edited

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

actions and reactions i18n #15058

actions and reactions i18n #15058

Conversation

yheuhtozr commented Oct 13, 2021 • edited by juliannatetreault

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

[Forem core team only] How will this change be communicated?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions bot commented Oct 13, 2021

yheuhtozr Oct 13, 2021 • edited

Choose a reason for hiding this comment

citizen428 Oct 18, 2021

Choose a reason for hiding this comment

juliannatetreault commented Oct 14, 2021

juliannatetreault left a comment

Choose a reason for hiding this comment

citizen428 left a comment

Choose a reason for hiding this comment

citizen428 commented Oct 21, 2021 • edited

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 13, 2021 •

edited by juliannatetreault

yheuhtozr Oct 13, 2021 •

edited

citizen428 commented Oct 21, 2021 •

edited