views/comments i18n #15059

yheuhtozr · 2021-10-13T02:32:41Z

What type of PR is this? (check all applicable)

Description

Extracts strings for i18n from app/views/comments and related. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).

Related Tickets & Documents

Relates to #14888

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

Yes
No, and this is why: please replace this line with details on why tests
have not been included
I need help with writing tests

[Forem core team only] How will this change be communicated?

Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.

I've updated the Developer Docs or
Storybook (for Crayons components)
This PR changes the Forem platform and our documentation needs to be
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
I've updated the README or added inline documentation
I've added an entry to
CHANGELOG.md
I will share this change in a Changelog
or in a forem.dev post
I will share this change internally with the appropriate teams
I'm not sure how best to communicate this change and need help
This change does not need to be communicated, and this is why not: this is ongoing work related to a large, ongoing initiative.

[optional] Are there any post deployment tasks we need to perform?

N/A

[optional] What gif best describes this PR or how it makes you feel?

github-actions · 2021-10-13T02:32:58Z

Thank you for opening this PR! We appreciate you!

For all pull requests coming from third-party forks we will need to
review the PR before we can process it through our CI pipelines.

A Forem Team member will review this contribution and get back to
you as soon as possible!

app/views/articles/_single_story.html.erb

app/views/articles/_widget_list_item.html.erb

config/locales/views/comments/en.yml

juliannatetreault · 2021-10-14T18:40:02Z

Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s main branch? i18n files weren’t being loaded properly and we have merged a fix for this. Thanks so much in advance and please do not hesitate to reach out if you need help!

citizen428

Approving pending the merge conflict resolution.

yheuhtozr · 2021-10-19T00:04:30Z

@citizen428 Do you perhaps mean pending conflicts resolved by me? If so, it says "conflicts are too complex to resolve in the web editor" and I don't commit to my GitHub repo directly.

citizen428 · 2021-10-19T04:12:41Z

Do you perhaps mean pending conflicts resolved by me?

Yes, I did. 😅

I don't commit to my GitHub repo directly

I'm not sure I understand.

yheuhtozr · 2021-10-19T11:11:46Z

@citizen428 My GitHub repo is just a mirror of GitLab. I tried to sync with the main branch but GitHub does not recognize it as resolution and still showing conflicts. Even though I can solve it here, it will be reverted at the next time I push anything to my GitLab repo. Hopefully now the conflicts are simple - you only have to accept all my changes, so if you don't mind, please resolve them immediately before you merge this PR.

BTW the reconciliation commit is rather big that you might want to check it again.

citizen428 · 2021-10-21T04:00:00Z

@yheuhtozr The spec errors here look legit, maybe something went wrong during the merge?

yheuhtozr · 2021-10-21T04:43:54Z

@citizen428 The template went through a rather complex rewrite that I can't pin down the error source for now. It might need a repush, so you can look for other PRs ready to merge if you don't mind.

citizen428 · 2021-10-21T04:49:21Z

Thanks for letting me know @yheuhtozr!

yheuhtozr · 2021-10-21T11:21:33Z

@citizen428 The last error Travis reports is two missing keys, but it doesn't miss anything on my local environment. Could you let me know which ones specifically?

citizen428 · 2021-10-25T07:57:34Z

@yheuhtozr Sure, the one key for views.comments.parent.view_full for both en and fr.

yheuhtozr · 2021-10-25T12:48:41Z

@citizen428 Now it fails with a mysterious error in a newly added(?) test, which doesn't look relevant to my changes?

config/locales/views/comments/en.yml

citizen428 · 2021-10-26T05:17:54Z

@yheuhtozr Looking into it.

Co-authored-by: Michael Kohl <citizen428@forem.com>

citizen428 · 2021-10-26T06:00:32Z

@yheuhtozr Re-ran the specs, they are green now.

aitchiss

Thanks for taking on these changes! I noticed just a couple of small issues, but otherwise all looking great 🔥

app/views/articles/_single_story.html.erb

app/views/comments/_comment_date.erb

aitchiss · 2021-10-27T08:38:35Z

app/views/comments/_comment_header.html.erb

-        <li class="mod-actions hidden mod-actions-comment-button" data-path="<%= URL.comment(comment) %>/mod" aria-label="Moderate <%= comment.user.name %>'s comment"></li>
-        <li class="report-abuse-link-wrapper" data-path="/report-abuse?url=<%= URL.comment(comment) %>" aria-label="Report <%= comment.user.name %>'s comment as abusive or violating our code of conduct and/or terms and conditions"></li>
+        <li class="mod-actions hidden mod-actions-comment-button" data-path="<%= URL.comment(comment) %>/mod" aria-label="<%= t("views.comments.menu.moderate.aria_label", user: comment.user.name) %>"></li>
+        <li class="report-abuse-link-wrapper" data-path="/report-abuse?url=<%= URL.comment(comment) %>" aria-label="<%= t("views.comments.menu.report.aria_label", user: comment.user.name) %>"></li>


(not blocking at all) Nice one adding the aria-label translations here - it's also made me notice that the labels aren't actually being attached to the inner buttons/links, only to the list item, so they're not having the desired effect.

This is still great though, and sets us up well to fix that in a later issue as it's nothing to do with your changes. Just wanted to say yay for bringing it to our attention!

aitchiss

Thanks for making that small fix!

* views/comments etc i18n * comments PR fixes * PR sync with main * remove ja.yml * Update _comment_header.html.erb * Update index.html.erb * Update _comment_header.html.erb * Update en.yml * Update fr.yml * Update config/locales/views/comments/en.yml Co-authored-by: Michael Kohl <citizen428@forem.com> * Update _comment_date.erb * Update en.yml * Update fr.yml Co-authored-by: Michael Kohl <citizen428@forem.com>

views/comments etc i18n

161132a

pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Oct 13, 2021

citizen428 reviewed Oct 13, 2021

View reviewed changes

app/views/articles/_single_story.html.erb Outdated Show resolved Hide resolved

app/views/articles/_widget_list_item.html.erb Outdated Show resolved Hide resolved

citizen428 reviewed Oct 14, 2021

View reviewed changes

config/locales/views/comments/en.yml Outdated Show resolved Hide resolved

comments PR fixes

179b952

yheuhtozr force-pushed the patch-comments-i18n-14888 branch from 036d36f to 6e8547e Compare October 15, 2021 11:16

citizen428 approved these changes Oct 18, 2021

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 18, 2021

yheuhtozr force-pushed the patch-comments-i18n-14888 branch from 6e8547e to 1b09775 Compare October 19, 2021 10:15

pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 19, 2021

yheuhtozr force-pushed the patch-comments-i18n-14888 branch from 1b09775 to eb7f981 Compare October 19, 2021 10:28

yheuhtozr added 2 commits October 19, 2021 19:30

PR sync with main

0c52b8b

remove ja.yml

15b74fa

yheuhtozr force-pushed the patch-comments-i18n-14888 branch from eb7f981 to 15b74fa Compare October 19, 2021 10:36

yheuhtozr mentioned this pull request Oct 19, 2021

views/podcasts, views/podcast_episodes i18n #15020

Merged

16 tasks

citizen428 requested a review from rhymes October 20, 2021 08:50

yheuhtozr force-pushed the patch-comments-i18n-14888 branch 2 times, most recently from 3cda498 to 15b74fa Compare October 20, 2021 09:12

juliannatetreault requested a review from benhalpern October 20, 2021 12:36

Merge branch 'main' into patch-comments-i18n-14888

51f918a

yheuhtozr added 3 commits October 21, 2021 19:22

Update _comment_header.html.erb

c8c413d

Update index.html.erb

a967342

Update _comment_header.html.erb

0d0bd6c

yheuhtozr added 2 commits October 25, 2021 20:18

Update en.yml

0aa875a

Update fr.yml

f715e90

citizen428 reviewed Oct 26, 2021

View reviewed changes

config/locales/views/comments/en.yml Outdated Show resolved Hide resolved

Update config/locales/views/comments/en.yml

f3b02b4

Co-authored-by: Michael Kohl <citizen428@forem.com>

citizen428 requested review from aitchiss and removed request for rhymes October 26, 2021 06:00

aitchiss reviewed Oct 27, 2021

View reviewed changes

yheuhtozr added 3 commits October 27, 2021 21:27

Update _comment_date.erb

e8ec98e

Update en.yml

923b93d

Update fr.yml

d3fb8d4

yheuhtozr mentioned this pull request Oct 27, 2021

I18nize articles & social_previews #15097

Merged

16 tasks

aitchiss approved these changes Oct 27, 2021

View reviewed changes

pr-triage bot added PR: partially-approved bot applied label for PR's where a single reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Oct 27, 2021

aitchiss merged commit f762acc into forem:main Oct 27, 2021

pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: partially-approved bot applied label for PR's where a single reviewer approves changes labels Oct 27, 2021

yheuhtozr mentioned this pull request Feb 11, 2023

Tweak i18n edited date format #19104

Merged

16 tasks

views/comments i18n #15059

views/comments i18n #15059

yheuhtozr commented Oct 13, 2021 •

edited by juliannatetreault

github-actions bot commented Oct 13, 2021

juliannatetreault commented Oct 14, 2021

citizen428 left a comment

yheuhtozr commented Oct 19, 2021

citizen428 commented Oct 19, 2021

yheuhtozr commented Oct 19, 2021 •

edited

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 25, 2021 •

edited

yheuhtozr commented Oct 25, 2021 •

edited

citizen428 commented Oct 26, 2021

citizen428 commented Oct 26, 2021

aitchiss left a comment

aitchiss Oct 27, 2021

aitchiss left a comment

views/comments i18n #15059

views/comments i18n #15059

Conversation

yheuhtozr commented Oct 13, 2021 • edited by juliannatetreault

What type of PR is this? (check all applicable)

Description

Related Tickets & Documents

QA Instructions, Screenshots, Recordings

UI accessibility concerns?

Added/updated tests?

[Forem core team only] How will this change be communicated?

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

github-actions bot commented Oct 13, 2021

juliannatetreault commented Oct 14, 2021

citizen428 left a comment

Choose a reason for hiding this comment

yheuhtozr commented Oct 19, 2021

citizen428 commented Oct 19, 2021

yheuhtozr commented Oct 19, 2021 • edited

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 21, 2021

yheuhtozr commented Oct 21, 2021

citizen428 commented Oct 25, 2021 • edited

yheuhtozr commented Oct 25, 2021 • edited

citizen428 commented Oct 26, 2021

citizen428 commented Oct 26, 2021

aitchiss left a comment

Choose a reason for hiding this comment

aitchiss Oct 27, 2021

Choose a reason for hiding this comment

aitchiss left a comment

Choose a reason for hiding this comment

yheuhtozr commented Oct 13, 2021 •

edited by juliannatetreault

yheuhtozr commented Oct 19, 2021 •

edited

citizen428 commented Oct 25, 2021 •

edited

yheuhtozr commented Oct 25, 2021 •

edited