Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch buffer gem to published version #1507

Merged
merged 1 commit into from Jan 10, 2019
Merged

Switch buffer gem to published version #1507

merged 1 commit into from Jan 10, 2019

Conversation

abraham
Copy link
Contributor

@abraham abraham commented Jan 9, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Switch the buffer gem to use the published version instead of the unstable source.

Related Tickets & Documents

#1473

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Tina Belcher using a rolling pin

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jan 9, 2019
@benhalpern
Copy link
Contributor

Oh awesome.

Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jan 10, 2019
@maestromac maestromac merged commit 37ebb5f into forem:master Jan 10, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jan 10, 2019
@abraham abraham deleted the pin-buffer branch January 10, 2019 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants