article editor and manager i18n #15070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this PR! We appreciate you! For all pull requests coming from third-party forks we will need to A Forem Team member will review this contribution and get back to |
|
Hey @yheuhtozr! 👋 Can you please update your branch with the latest code from the repository’s |
citizen428
reviewed
Oct 15, 2021
There was a problem hiding this comment.
I left a few non-blocking suggestions. Thank you for working on this, @yheuhtozr!
yheuhtozr
force-pushed
the
patch-editor-manager-i18n-14888
branch
from
1698f2f
to
71a8766
Compare
juliannatetreault
approved these changes
Oct 19, 2021
pr-triage
bot
added
PR: partially-approved
citizen428
approved these changes
Oct 21, 2021
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
citizen428
pushed a commit
that referenced
this pull request
Oct 29, 2021
* article editor, manager i18n * PR key name changes * remove ja.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Extracts strings for i18n from article editor & manage templates. Attached fr locale for testing purposes. Existing translations up to #15002 reflected (hopefully).
Related Tickets & Documents
Relates to #14888
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
Added/updated tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
[optional] Are there any post deployment tasks we need to perform?
N/A
[optional] What gif best describes this PR or how it makes you feel?