Refactor RssReader #1537
Merged
Refactor RssReader #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maestromac
commented
Jan 14, 2019
| next if feed_url == "" | ||
|
|
||
| create_articles_for_user(u) | ||
| User.where.not(feed_url: [nil, ""]).find_each do |user| |
There was a problem hiding this comment.
Changed to find_each in the hope that it reduce chances of SIGTERM
maestromac
force-pushed
the
bug/1439-improve-rss-feed-fetching
branch
from
e7ab377
to
fae41a9
Compare
pr-triage
bot
removed
the
PR: unreviewed
benhalpern
approved these changes
Jan 14, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
RssReader toservices/RssReadertoRssReader::AssemblerRelated Tickets & Documents
#1439
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
n/a
Added to documentation?