Replace each with find_each for ActiveRecord queries #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benhalpern
approved these changes
Jan 15, 2019
There was a problem hiding this comment.
Looks good. This is mostly stuff where the total number of returned instances is low enough that each is sort of fine, but find_each definitely makes sense here, especially as raw numbers in the app grow.
Thinking outloud: What about further optimizing in terms of lowering the batch_size in some of these cases where large objects are loaded into memory?
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
|
@benhalpern it makes sense, altough you might need a profiler to know exactly how the app is behaving. Something like rack-mini-profiler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Using
.eachon an ActiveRecord relation object means that AR is going to load all objects in memory, which is almost always not the intended behavior. It can also be problematic if such queries load a lot of objects in memory when executed.I've replaced it with
.find_eachwhich by default loads only 1000 rows at a time, and then moves on to the next 1000.This scales well when there are just too many rows to process all at once.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?