Super small queries optimizations

[rhymes]

What type of PR is this? (check all applicable)

• Refactor
• Feature
• Bug Fix
• Documentation Update

Description

I applied two micro optimizations, more in the spirit of following good practices than actual overall performance improvements.

1. replaced find_by().nil? with exists? because in those situations the object loaded by find_by is never used, thus is more efficient in general to just ask the DB for what you actually want (in this case to reply to the question asked by the nil? predicate)

2. replaced any? with present? to populate the list of users of an organization. The reasoning is the following: most organizations will most likely exist with users than without, so we use present? which preloads the list of users used by the subsequent iteration. Hence 1 query instead of 2.

Related Tickets & Documents

This is most definitely the result of me digging through the code after reading 3 ActiveRecord Mistakes That Slow Down Rails Apps: Count, Where and Present.

I'm well aware that these two optimizations don't amount to much at the end of the day, it's more an attempt to hopefully cement good practices when they make sense.

At a first glance I didn't find anything else (though I didn't feel comfortable enough to delve in possible where() optimizations TBH, especially without hard numbers in front of me), so kudos to everyone!

Well, I already knew dev.to was fast 🔥

Added to documentation?

• docs.dev.to
• readme
• no documentation needed

[Link2Twenty]

Can present? not be replaced by exists? too?

[rhymes]

Can present? not be replaced by exists? too?

It depends on the context but I didn't find any suspicious present? attached to ignored relations in the code. I might have missed something of course :)