Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display tag moderators on tag page #1739

Merged
merged 4 commits into from Feb 12, 2019

Conversation

seanmfox
Copy link
Contributor

@seanmfox seanmfox commented Feb 5, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Each tag page shows a list of the tag moderators in the left sidebar. The formatting matches that used for the 'meet the team' sidebar on the organization page.

Related Tickets & Documents

#1677

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image

image

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 5, 2019
@jessleenyc jessleenyc self-assigned this Feb 5, 2019
Copy link
Contributor

@jessleenyc jessleenyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 12, 2019
@jessleenyc jessleenyc removed their assignment Feb 12, 2019
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your pr @seanmfox

@maestromac maestromac merged commit 1acd5b7 into forem:master Feb 12, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 12, 2019
@jessleenyc
Copy link
Contributor

@seanmfox would you like to write a #changelog post about this new feature?!

@seanmfox
Copy link
Contributor Author

@jessleenyc Definitely! I'll put something together tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants