Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the number of sql queries for articles comments #1606 #1766

Merged
merged 5 commits into from Feb 16, 2019

Conversation

lightalloy
Copy link
Contributor

@lightalloy lightalloy commented Feb 8, 2019

What type of PR is this? (check all applicable)

  • Refactor

Description

Eliminate N+1 while loading articles comments.

Related Tickets & Documents

#1606

Added to documentation?

  • no documentation needed

@lightalloy lightalloy changed the title [WIP] Reduce the number of sql queries for articles comments #1606 Reduce the number of sql queries for articles comments #1606 Feb 13, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 13, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 16, 2019
@benhalpern benhalpern merged commit 1cc0fcc into forem:master Feb 16, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 16, 2019
@lightalloy lightalloy deleted the reduce-comments-queries branch February 18, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants