Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'me' value to 'rel' tag on Mastodon URL on profile #1792

Merged
merged 1 commit into from Feb 13, 2019
Merged

Add 'me' value to 'rel' tag on Mastodon URL on profile #1792

merged 1 commit into from Feb 13, 2019

Conversation

nikoheikkila
Copy link
Contributor

Hi there! 馃憢

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Attempting my first contribution here. I noticed that when you set a Mastodon URL on your profile the link does not contain a rel=me attribute. This is required for Mastodon instances to recognize the link between instance and dev.to to be real. This should fix it.

Related Tickets & Documents

None.

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

No UI changes. Verify this feature by investigating the generated Mastodon URL from source.

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed (probably?)

[optional] What gif best describes this PR or how it makes you feel?

TOOT

This is required for Mastodon instances to recognize the link between
instance and dev.to to be real.
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Feb 12, 2019
@CLAassistant
Copy link

CLAassistant commented Feb 12, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Zhao-Andy Zhao-Andy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is safe so looks good to me! Do you mind sharing some resources about rel="me"? Personally have not heard of it.

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Feb 13, 2019
@nikoheikkila
Copy link
Contributor Author

I think this is safe so looks good to me! Do you mind sharing some resources about rel="me"? Personally have not heard of it.

It's hard to find good documentation about this but it's described on their changelog for version 2.6.

Here's a screenshot of my settings page:

Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your PR

@maestromac maestromac merged commit 81c889b into forem:master Feb 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Feb 13, 2019
@nikoheikkila nikoheikkila deleted the feature/verify-mastodon-url branch February 13, 2019 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants