add a field for users to display whether or not they allow article edits #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessleenyc
requested changes
Feb 15, 2019
| @@ -0,0 +1,5 @@ | |||
| class AddAllowsArticleEditsToUsers < ActiveRecord::Migration[5.1] | |||
| def change | |||
| add_column :users, :allows_article_edits, :boolean, default: false | |||
There was a problem hiding this comment.
I think we actually want this to default to true
There was a problem hiding this comment.
Cool, that makes sense!
app/views/users/_profile.html.erb
Outdated
| @@ -45,7 +45,10 @@ | |||
| </span> | |||
| <% end %> | |||
| </div> | |||
|
|
|||
| <div class="field checkbox-label-first"> | |||
| <%= f.label :allows_article_edits, "Allow admins to edit typos in my articles" %> | |||
There was a problem hiding this comment.
I think this should be "Allow admins to edit typos or adjust formatting in my articles." Wanted to add the formatting part because sometimes we adjust markdown errors.
There was a problem hiding this comment.
totally -- will add
| @@ -48,7 +48,8 @@ def moderation_routes? | |||
| end | |||
|
|
|||
| def permitted_attributes | |||
| %i[available_for | |||
| %i[allows_article_edits | |||
There was a problem hiding this comment.
I think this might make more sense under /settings/misc.
pr-triage
bot
added
PR: reviewed-changes-requested
pr-triage
bot
added
PR: unreviewed
Zhao-Andy
reviewed
Feb 20, 2019
|
I think it should be resolved! |
Zhao-Andy
approved these changes
Feb 20, 2019
pr-triage
bot
added
PR: reviewed-approved
jessleenyc
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds a flag to profiles so users can state whether they want admins to be able to fix typos and such.
Related Tickets & Documents
#1539
Mobile & Desktop Screenshots/Recordings (if there are UI changes)
Added to documentation?
[optional] What gif best describes this PR or how it makes you feel?