Use include instead as a better check #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maestromac
approved these changes
Feb 15, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
glebec
reviewed
Mar 1, 2019
| @@ -66,13 +66,9 @@ def self.script | |||
| end | |||
|
|
|||
| def sanitized_preamble(markup) | |||
| raise StandardError, "Runkit tag is invalid" if markup.ends_with? "\">" | |||
| raise StandardError, "Runkit tag is invalid" if markup.include? "\"" | |||
There was a problem hiding this comment.
This line prevents the use of double quotes, not the use of > characters. This breaks all runkit preambles that use double-quoted strings. For example, the following is now a minimal example of an invalid runkit tag:
{% runkit "" %}
{% endrunkit %}
Whereas this is fine:
{% runkit '' %}
{% endrunkit %}
This was referenced Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
use
includeinstead ofstart_withandend_withas recommended for a more secure check.