New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✂️✂️✂️ Remove API v0 support ✂️✂️✂️ #19062
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Uffizzi Preview Environment
|
Codecov ReportBase: 80.17% // Head: 79.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #19062 +/- ##
==========================================
- Coverage 80.17% 79.96% -0.21%
==========================================
Files 1136 1102 -34
Lines 25012 24835 -177
Branches 1758 1769 +11
==========================================
- Hits 20054 19860 -194
- Misses 4709 4723 +14
- Partials 249 252 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| include Api::Admin::UsersController | ||
|
|
||
| before_action :authenticate! | ||
| before_action :authorize_super_admin | ||
|
|
||
| def create | ||
| # NOTE: We can add an inviting user here, e.g. User.invite!(current_user, user_params). | ||
| User.invite!(user_params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what you'll find in all v1 controllers: Removing the include of the concern and inclusion of the concern code itself in the controller
|
I will close this for now. When we decide how to move forward, we can open with a new PR |
What type of PR is this? (check all applicable)
Description
After the transition period and now that the API V1 docs are ready we're in shape to get rid of the old V0 API endpoints and stick with the new major version going forward.
This PR gets rid of the concerns extraction of logic (used to avoid repeating the code on shared controllers) so it will all be easier to find/understand in the codebase.
Related Tickets & Documents
N/A
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
None - backend change
Added/updated tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
This is a sensitive change. I strongly recommend some manual monitoring over the next hour or two after this is merged to ensure no edge case scenarios are causing an elevated amount of user facing errors
[optional] What gif best describes this PR or how it makes you feel?