Change notifications unique indexes #2525

[lightalloy]

What type of PR is this? (check all applicable)

• Bug Fix

Description

• сhanged notifications indexes so that they take into account possible null values in user_id, organization_id, action fields
  Postgres allows to create records which contain the same fields if some of them contain null values, so I
  • created separate indexes for user_id and organization_id because notifications has either user_id or organization_id
  • made partial indexes for cases when action is null and when it's not null
• added specs to check that notifications are not duplicated even when validations are skipped

Before merging, all the notifications that have duplicate fields %i[user_id organization_id notifiable_id notifiable_type action] must be deleted

Related Tickets & Documents

#2525

[rhymes]

Really good work @lightalloy ! I guess it needs to rebase or regenerate the schema.rb

Since we can't use foreign keys here, unique indexes are definitely of help!

[lightalloy]

@rhymes thanks for reminding! I'll dot it.

[Zhao-Andy]

Code looks great! Going to reiterate your point before merging:

Before merging, all the notifications that have duplicate fields %i[user_id organization_id notifiable_id notifiable_type action] must be deleted.

[Zhao-Andy]

Approving now that concurrent migrations are in place 👍

Before merging, all the notifications that have duplicate fields %i[user_id organization_id notifiable_id notifiable_type action] must be deleted.