Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ActiveJob for Mention #3055

Merged
merged 4 commits into from Jun 13, 2019
Merged

Implement ActiveJob for Mention #3055

merged 4 commits into from Jun 13, 2019

Conversation

tannakartikey
Copy link
Contributor

@tannakartikey tannakartikey commented Jun 6, 2019 •
edited

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Implemented ActiveJob for the following methods on Mention:

  • Mention.create_all
  • Mention#send_email_notification

Related Tickets & Documents

#2497

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 6, 2019
@tannakartikey tannakartikey force-pushed the 2497_active_job_models_mention branch from 6b09fba to 6d9d5ee Compare June 6, 2019 03:33
@tannakartikey tannakartikey force-pushed the 2497_active_job_models_mention branch from 6d9d5ee to 852d0fc Compare June 6, 2019 03:38
lightalloy
lightalloy requested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@lightalloy lightalloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another pr! I made several comments/suggestions in a review.
I have also noticed several rubocop rules violations. Please, run rubocop before committing and fix those related to your changes.

app/jobs/mentions/create_all_job.rb Show resolved Hide resolved
app/models/mention.rb Outdated Show resolved Hide resolved
spec/services/mentions_create_all_service_spec.rb Outdated Show resolved Hide resolved
app/services/mentions_create_all_service.rb Outdated Show resolved Hide resolved
spec/jobs/mentions/create_all_job_spec.rb Outdated Show resolved Hide resolved
spec/jobs/mentions/create_all_job_spec.rb Outdated Show resolved Hide resolved
@pr-triage pr-triage bot added PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 6, 2019
@pr-triage pr-triage bot added PR: unreviewed bot applied label for PR's with no review and removed PR: reviewed-changes-requested bot applied label for PR's where reviewer requests changes labels Jun 7, 2019
@tannakartikey
Copy link
Contributor Author

@lightalloy thanks for the review. I have implemented the changes.

@weekly-digest weekly-digest bot mentioned this pull request Jun 10, 2019
Closed
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 10, 2019
@benhalpern benhalpern merged commit 858ce18 into forem:master Jun 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 13, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhymes rhymes rhymes left review comments

@lightalloy lightalloy lightalloy approved these changes

Assignees
No one assigned
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tannakartikey @lightalloy @rhymes @benhalpern