Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting default reading time of 1 minute for articles within liquid tags #3084

Merged
merged 2 commits into from Jun 14, 2019
Merged

Setting default reading time of 1 minute for articles within liquid tags #3084

merged 2 commits into from Jun 14, 2019

Conversation

jrsam
Copy link
Contributor

@jrsam jrsam commented Jun 9, 2019

resolves #3024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 9, 2019
@weekly-digest weekly-digest bot mentioned this pull request Jun 10, 2019
Closed
@maestromac maestromac self-assigned this Jun 13, 2019
maestromac
maestromac approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 14, 2019
@maestromac maestromac merged commit 74ecf5c into forem:master Jun 14, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 14, 2019
@jrsam jrsam deleted the bug/fix-unmatched-reading-time branch June 15, 2019 07:02
@weekly-digest weekly-digest bot mentioned this pull request Jun 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maestromac maestromac maestromac approved these changes

Assignees

@maestromac maestromac

Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reading time estimate does not match for a particular post
2 participants
@jrsam @maestromac