Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading list filters input's color in night theme #3089

Merged

Conversation

sunchayn
Copy link
Contributor

@sunchayn sunchayn commented Jun 9, 2019

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

This fixes the input's color of the reading list filters in night theme ( or any future theme that does not have black as theme color )

reading list filter

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

before
before

after
after

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 9, 2019
@CLAassistant
Copy link

CLAassistant commented Jun 9, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mariocsee mariocsee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 10, 2019
@maestromac maestromac merged commit 95ba660 into forem:master Jun 11, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants