Removed fetching podcasts from a callback #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lightalloy
force-pushed
the
refactor-fetch-podcasts
branch
from
afcef02
to
f580041
Compare
lightalloy
force-pushed
the
refactor-fetch-podcasts
branch
from
f580041
to
a9945fb
Compare
lightalloy
changed the title
rhymes
approved these changes
Jun 12, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
after_createcallback for fetching podcast episodes/admin/podcasts/newCreating a podcast and fetching episodes shouldn't be tightly coupled. We sometimes want to create a podcast without fetching episodes, e.g. for tests or for seeding the database.
Related Tickets & Documents
#2952