Dashboard Pro: support InstantClick and show org analytics #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhymes
changed the title
rhymes
changed the title
pr-triage
bot
removed
the
PR: unreviewed
rhymes
changed the title
rhymes
changed the title
|
I'm ignoring CC's errors because I don't think fixing them adds value to the code base at this point. They'll probably end up being fixed in the future when we have multiple places where we show analytics |
rhymes
changed the title
|
👍 looks great to me! |
7 tasks
benhalpern
approved these changes
Jun 12, 2019
pr-triage
bot
added
PR: reviewed-approved
pr-triage
bot
added
PR: merged
pr-triage
bot
added
PR: reviewed-approved
22 tasks
This was referenced Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR makes the Pro Dashboard work with InstantClick and displays the correct analytics for organizations.
It moves all the code inside functions, removing globals and then loads the "initializer" inside InstantClick
changeevent so that the transition between clicks is smooth.Right now, if you have your own dashboard and your organization's dashboard, clicking between the two doesn't work. Also, if you go from https://dev.to/dashboard to https://dev.to/dashboard/pro from the internal link you have to refresh the page.
Another thing it does is to display the correct analytics for the organization. Right now we never pass the organization ID to the analytics business logic, which means that the data returned it's always that of the user, not that of the organization the user is looking at.
Added to documentation?