Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/Action Buttons Fix #3110

Merged
merged 1 commit into from Jun 11, 2019

Conversation

bdlb77
Copy link
Contributor

@bdlb77 bdlb77 commented Jun 10, 2019

Bug Fix - Action Space

Buttons Edit and Manage | Add inline-flex to have action buttons always on same line

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Documentation Update

Description

Fixes the Action Space Buttons on Mobile to display in the same line. Added display: inline-flex to have the elements always maintain the same horizontal space.. causing them to wrap around together when there isn't enough space

Related Tickets & Documents

Fixes #3061

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screen Shot 2019-06-10 at 8 19 40 PM

Screen Shot 2019-06-10 at 8 20 01 PM

Added to documentation?

  • docs.dev.to
  • readme
  • no documentation needed

[optional] What gif best describes this PR or how it makes you feel?

Peter Griffin Struggling to roll up a window shade

Add inline-flex to have action buttons always on same line
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 10, 2019
@CLAassistant
Copy link

CLAassistant commented Jun 10, 2019

CLA assistant check
All committers have signed the CLA.

@bdlb77
Copy link
Contributor Author

bdlb77 commented Jun 10, 2019

It was hard to test the exact iPhone XS usecase since I don't have the phone myself.. but on my iPhone 8 and within the virtual inspectors on the browser, they seemed to be fine :)

Copy link
Member

@maestromac maestromac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ignore the fail specs. Those aren't related

@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 11, 2019
@maestromac maestromac merged commit fa7079e into forem:master Jun 11, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action space buttons "manage" and "edit" not inline on mobile
3 participants