Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Podcasts validations #3123

Merged
merged 4 commits into from Jun 13, 2019
Merged

Conversation

lightalloy
Copy link
Contributor

@lightalloy lightalloy commented Jun 11, 2019

What type of PR is this? (check all applicable)

  • Bug Fix

Description

Implemented proper validations for podcasts and podcast episodes to avoid failing in the future.

  • added model validations: fields presence, slug uniqueness, slug uniqueness with usernames and organization slugs
  • added db constraints
  • added validation specs

Before merging need to check that all the podcasts and podcast_episodes records don't violate the provided constraints (non-null values and uniqueness)

Related Tickets & Documents

#271
https://github.com/thepracticaldev/team/issues/177

@lightalloy lightalloy marked this pull request as ready for review June 12, 2019 10:03
@lightalloy lightalloy changed the title [WIP] Podcasts validations Podcasts validations Jun 12, 2019
@pr-triage pr-triage bot added the PR: unreviewed bot applied label for PR's with no review label Jun 12, 2019
@pr-triage pr-triage bot added PR: reviewed-approved bot applied label for PR's where reviewer approves changes and removed PR: unreviewed bot applied label for PR's with no review labels Jun 13, 2019
@benhalpern benhalpern merged commit f476e11 into forem:master Jun 13, 2019
@pr-triage pr-triage bot added PR: merged bot applied label for PR's that are merged and removed PR: reviewed-approved bot applied label for PR's where reviewer approves changes labels Jun 13, 2019
@lightalloy lightalloy deleted the team-177-podcasts_validation branch June 14, 2019 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: merged bot applied label for PR's that are merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants